[PATCH v2] bus: fsl-mc: dpio: fix alter FQ state command

From: Horia GeantÄ
Date: Sat Apr 22 2017 - 02:46:07 EST


When checking the response verb, the valid bit should be masked out,
since its value flips depending on what Response Register
(RR0 /RR1) it's been read from.

Fixes: 321eecb06bfb ("bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2")
Signed-off-by: Horia GeantÄ <horia.geanta@xxxxxxx>
---
v2: use QBMAN_RESULT_MASK instead of hard-coded mask

drivers/staging/fsl-mc/bus/dpio/qbman-portal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c b/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c
index 2a3ea29d9b43..7988612aaecf 100644
--- a/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c
+++ b/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c
@@ -963,7 +963,7 @@ int qbman_swp_alt_fq_state(struct qbman_swp *s, u32 fqid,
}

/* Decode the outcome */
- WARN_ON(r->verb != alt_fq_verb);
+ WARN_ON((r->verb & QBMAN_RESULT_MASK) != alt_fq_verb);

/* Determine success or failure */
if (unlikely(r->rslt != QBMAN_MC_RSLT_OK)) {
--
2.12.0.264.gd6db3f216544