Re: [PATCH 6/9] T10: Move opencoded contants to common header

From: Martin K. Petersen
Date: Wed Apr 19 2017 - 22:44:45 EST


Dmitry Monakhov <dmonakhov@xxxxxxxxxx> writes:

Dmitry,

> diff --git a/include/linux/t10-pi.h b/include/linux/t10-pi.h
> index 9fba9dd..f892442 100644
> --- a/include/linux/t10-pi.h
> +++ b/include/linux/t10-pi.h
> @@ -33,6 +33,8 @@ struct t10_pi_tuple {
> __be32 ref_tag; /* Target LBA or indirect LBA */
> };
>
> +#define T10_APP_ESCAPE cpu_to_be16(0xffff)
> +#define T10_REF_ESCAPE cpu_to_be32(0xffffffff)

T10 just means SCSI and does not imply protection information. Please
make these T10_PI_{REF,APP}_ESCAPE (ideally in an enum).

--
Martin K. Petersen Oracle Linux Engineering