Re: [PATCH 1/2] usb: dwc2: Remove unnecessary debug prints

From: Joe Perches
Date: Wed Apr 19 2017 - 17:56:05 EST


On Wed, 2017-04-19 at 15:16 +0400, Razmik Karapetyan wrote:
> Removed unnecessary debug prints about DMA mode for host side
> from dwc2_gahbcfg_init() function.

Why are these unnecessary? Are these emitted elsewhere?

and...

> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
[]
> @@ -302,22 +302,10 @@ static int dwc2_gahbcfg_init(struct dwc2_hsotg *hsotg)
[]
> if (hsotg->params.host_dma)
> ahbcfg |= GAHBCFG_DMA_EN;
> + else
> + hsotg->params.dma_desc_enable = false;

This change isn't mentioned in the commit message.
Why is is useful?