Re: [PATCH 17/29] drivers, pci: convert hv_pci_dev.refs from atomic_t to refcount_t

From: Bjorn Helgaas
Date: Tue Apr 18 2017 - 10:05:49 EST


On Tue, Apr 18, 2017 at 5:40 AM, Reshetova, Elena
<elena.reshetova@xxxxxxxxx> wrote:
>
>
>> On Mon, 6 Mar 2017 15:38:29 -0600
>> Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
>>
>> > [+cc Hyper-V folks, -cc others]
>> >
>> > On Mon, Mar 06, 2017 at 04:21:04PM +0200, Elena Reshetova wrote:
>> > > refcount_t type and corresponding API should be
>> > > used instead of atomic_t when the variable is used as
>> > > a reference counter. This allows to avoid accidental
>> > > refcounter overflows that might lead to use-after-free
>> > > situations.
>> > >
>> > > Signed-off-by: Elena Reshetova <elena.reshetova@xxxxxxxxx>
>> > > Signed-off-by: Hans Liljestrand <ishkamiel@xxxxxxxxx>
>> > > Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>> > > Signed-off-by: David Windsor <dwindsor@xxxxxxxxx>
>>
>>
>> Reviewed-by: Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>
>
> Getting back on this: could you take the patch via your tree or should I resubmit to some dedicated place with a new review-by added?

Sorry, for some reason I had assumed this would all go as part of the
larger series. I applied it to my pci/host-hv branch with Stephen's
reviewed-by for v4.12.

Thanks for the ping!

Bjorn