Re: [patch 15/20] x86/perf: Drop EXPORT of perf_check_microcode

From: Borislav Petkov
Date: Tue Apr 18 2017 - 07:24:39 EST


On Sat, Apr 15, 2017 at 07:01:22PM +0200, Thomas Gleixner wrote:
> The only caller is the microcode update, which cannot be modular.
>
> Drop the export.
>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Borislav Petkov <bp@xxxxxxxxx>
> Cc: x86@xxxxxxxxxx
> ---
> arch/x86/events/core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- a/arch/x86/events/core.c
> +++ b/arch/x86/events/core.c
> @@ -2224,7 +2224,6 @@ void perf_check_microcode(void)
> if (x86_pmu.check_microcode)
> x86_pmu.check_microcode();
> }
> -EXPORT_SYMBOL_GPL(perf_check_microcode);
>
> static struct pmu pmu = {
> .pmu_enable = x86_pmu_enable,

Acked-by: Borislav Petkov <bp@xxxxxxx>

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.