Re: [PATCH] ide: don't call memcpy with the same source and destination

From: Bartlomiej Zolnierkiewicz
Date: Tue Apr 18 2017 - 06:59:10 EST



On Friday, April 14, 2017 02:35:33 PM Mikulas Patocka wrote:
> The parisc architecture recently reimplemented the memcpy function and
> their reimplementation crashed when source and destination overlapped.
>
> The crash happened in the function ide_complete_cmd where memcpy is called
> with the same source and destination pointer. According to the C
> specification, memcpy behavior is undefined if the source and destination
> range overlaps. This patches fixes the undefined behavior.
>
> Signed-off-by: Mikulas Patocka <mpatocka@xxxxxxxxxx>

Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics