Re: [PATCH 2/2 v2] char: misc: use octal permissions for the proc entry

From: Martin Kaiser
Date: Tue Apr 18 2017 - 03:51:37 EST


Thus wrote Greg Kroah-Hartman (gregkh@xxxxxxxxxxxxxxxxxxx):

> > - ret = proc_create("misc", 0, NULL, &misc_proc_fops);
> > + ret = proc_create("misc", 0444, NULL, &misc_proc_fops);

> What checkpatch warning does this fix? 0 is a number :)

ERROR: Use 4 digit octal (0777) not decimal permissions
#285: FILE: drivers/char/misc.c:285:
+ ret = proc_create("misc", 0, NULL, &misc_proc_fops);

Best regards,

Martin