Re: [PATCH -mm -v8 1/3] mm, THP, swap: Delay splitting THP during swap out

From: Johannes Weiner
Date: Fri Apr 14 2017 - 10:59:25 EST


Hi Huang,

I reviewed this patch based on the feedback I already provided, but
eventually gave up and rewrote it. Please take review feedback more
seriously in the future.

Attached below is the reworked patch. Most changes are to the layering
(page functions, cluster functions, range functions) so that we don't
make the lowest swap range code require a notion of huge pages, or
make the memcg page functions take size information that can be
gathered from the page itself. I turned the config symbol into a
generic THP_SWAP that can later be extended when we add 2MB IO. The
rest is function naming, #ifdef removal etc.

Please review whether this is an acceptable version for you.

Thanks

---