Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from 'atomic'

From: Luck, Tony
Date: Wed Apr 12 2017 - 16:52:37 EST


On Wed, Apr 12, 2017 at 01:27:05PM -0700, Verma, Vishal L wrote:
> >   /* We only care about memory errors */
> >   if (!(mce->status & MCACOD))
> >   return NOTIFY_DONE;

N.B. that isn't a valid test that this is a memory error. You need


if (!(m->status & 0xef80) == BIT(7))
return NOTIFY_DONE;

See: Intel SDM Volume 3B - 15.9.2 Compound Error Codes

-Tony