Re: [PATCH] um: use KERN_CONT in stack dump

From: Vegard Nossum
Date: Tue Apr 11 2017 - 05:36:23 EST


On 12 March 2017 at 10:47, Vegard Nossum <vegard.nossum@xxxxxxxxxx> wrote:
> On 12/03/2017 10:45, Richard Weinberger wrote:
>> diff --git a/arch/um/kernel/sysrq.c b/arch/um/kernel/sysrq.c
>> index aa1b56f5ac68..18eddf677ec6 100644
>> --- a/arch/um/kernel/sysrq.c
>> +++ b/arch/um/kernel/sysrq.c
>> @@ -17,10 +17,8 @@
>>
>> static void _print_addr(void *data, unsigned long address, int reliable)
>> {
>> - pr_info(" [<%08lx>]", address);
>> - pr_cont(" %s", reliable ? "" : "? ");
>> - print_symbol("%s", address);
>> - pr_cont("\n");
>> + pr_info(" [<%08lx>] %s%pB\n", address, reliable ? "" : "? ",
>> + (void *)address);
>> }
>
> Tested-by: Vegard Nossum <vegard.nossum@xxxxxxxxxx>

Just a heads up, this still appears unfixed in Linus's repo.


Vegard