Re: [PATCH 2/2] drivers: char: Replace fail_printk with fail_print.

[Greg Kroah-Hartman]

On Mon, Apr 10, 2017 at 12:29:56PM +0530, Varsha Rao wrote:
> As printk is no longer used here, rename the label fail_printk as
> fail_print.
> 
> Signed-off-by: Varsha Rao <rvarsha016@xxxxxxxxx>
> ---
>  drivers/char/misc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/char/misc.c b/drivers/char/misc.c
> index 5786281..0fed477 100644
> --- a/drivers/char/misc.c
> +++ b/drivers/char/misc.c
> @@ -293,11 +293,11 @@ static int __init misc_init(void)
>  
>  	err = -EIO;
>  	if (register_chrdev(MISC_MAJOR, "misc", &misc_fops))
> -		goto fail_printk;
> +		goto fail_print;
>  	misc_class->devnode = misc_devnode;
>  	return 0;
>  
> -fail_printk:
> +fail_print:
>  	pr_err("unable to get major %d for misc devices\n", MISC_MAJOR);
>  	class_destroy(misc_class);

That's really a pointless change, don't you think?

sorry,

greg k-h