Re: [HMM 10/16] mm/hmm/mirror: helper to snapshot CPU page table v2

From: Michal Hocko
Date: Mon Apr 10 2017 - 04:35:14 EST


On Wed 05-04-17 16:40:20, Jérôme Glisse wrote:
> This does not use existing page table walker because we want to share
> same code for our page fault handler.

I am getting the following compilation error with sparc32
allmodconfig. I didn't check more closely yet.

mm/hmm.c: In function 'hmm_vma_walk_pmd':
mm/hmm.c:370:53: error: macro "pte_index" requires 2 arguments, but only 1 given
unsigned long pfn = pmd_pfn(pmd) + pte_index(addr);
^
mm/hmm.c:370:39: error: 'pte_index' undeclared (first use in this function)
unsigned long pfn = pmd_pfn(pmd) + pte_index(addr);
^
mm/hmm.c:370:39: note: each undeclared identifier is reported only once for each function it appears in
mm/hmm.c: In function 'hmm_devmem_release':
mm/hmm.c:816:2: error: implicit declaration of function 'arch_remove_memory' [-Werror=implicit-function-declaration]
arch_remove_memory(align_start, align_size, devmem->pagemap.type);
^
cc1: some warnings being treated as errors
--
Michal Hocko
SUSE Labs