Re: [net-next PATCH v2 3/8] net: Only define skb_mark_napi_id in one spot instead of two

From: Eric Dumazet
Date: Thu Mar 23 2017 - 21:02:34 EST


On Thu, 2017-03-23 at 14:36 -0700, Alexander Duyck wrote:
> From: Alexander Duyck <alexander.h.duyck@xxxxxxxxx>
>
> Instead of defining two versions of skb_mark_napi_id I think it is more
> readable to just match the format of the sk_mark_napi_id functions and just
> wrap the contents of the function instead of defining two versions of the
> function. This way we can save a few lines of code since we only need 2 of
> the ifdef/endif but needed 5 for the extra function declaration.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@xxxxxxxxx>
> ---
> include/net/busy_poll.h | 22 +++++++++-------------
> 1 file changed, 9 insertions(+), 13 deletions(-)

Acked-by: Eric Dumazet <edumazet@xxxxxxxxxx>