Re: [PATCH 22/46] selinux: Delete an unnecessary variable initialisation in range_read()

From: Paul Moore
Date: Thu Mar 23 2017 - 18:18:09 EST


On Sun, Jan 15, 2017 at 10:22 AM, SF Markus Elfring
<elfring@xxxxxxxxxxxxxxxxxxxxx> wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Sat, 14 Jan 2017 20:40:12 +0100
>
> The local variable "rt" will be set to an appropriate pointer a bit later.
> Thus omit the explicit initialisation at the beginning which became
> unnecessary with a previous update step.
>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---
> security/selinux/ss/policydb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Merged, thanks.

> diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c
> index 0d2f64558c0a..6121a26ada64 100644
> --- a/security/selinux/ss/policydb.c
> +++ b/security/selinux/ss/policydb.c
> @@ -1839,7 +1839,7 @@ u32 string_to_av_perm(struct policydb *p, u16 tclass, const char *name)
>
> static int range_read(struct policydb *p, void *fp)
> {
> - struct range_trans *rt = NULL;
> + struct range_trans *rt;
> struct mls_range *r = NULL;
> int i, rc;
> __le32 buf[2];
> --
> 2.11.0
>



--
paul moore
www.paul-moore.com