Re: [v1 0/9] Early boot time stamps for x86

From: Thomas Gleixner
Date: Thu Mar 23 2017 - 14:41:04 EST


On Thu, 23 Mar 2017, Pasha Tatashin wrote:
> I will add a condition to tsc_early_init() to check for TSC_ADJUST if it is
> not 0, disable early TSC feature. Does this sound OK?

Not really.

I have strong objections against how this is crammed into the early boot
process along with the code duplication and the extra magic which is
caused by this.

The early boot process is fragile enough, so we really only want to have
code there which is absolutely required. That timestamp feature does not
qualify for that at all.

I need some quiet time to look into that, so please don't waste too much
time on refactoring that patch set.

Thanks,

tglx