Re: [PATCH v2] kasan: report only the first error by default

From: Mark Rutland
Date: Thu Mar 23 2017 - 09:29:35 EST


On Thu, Mar 23, 2017 at 04:06:59PM +0300, Andrey Ryabinin wrote:
> On 03/23/2017 03:41 PM, Mark Rutland wrote:

> > Rather than trying to pick an arbitrarily large number, how about we use
> > separate flags to determine whether we're in multi-shot mode, and
> > whether a (oneshot) report has been made.
> >
> > How about the below?
>
> Yes, it deferentially looks better.
> Can you send a patch with a changelog, or do you want me to care of it?

Would you be happy to take care of it, along with the fixup you
suggested below, as v3?

You can add my:

Signed-off-by: Mark Rutland <mark.rutland@xxxxxxx>

Thanks,
Mark.


> >
> > +#include <linux/bitops.h>
> > #include <linux/ftrace.h>
>
> We also need <linux/init.h> for __setup().
>
> > #include <linux/kernel.h>
> > #include <linux/mm.h>
> > @@ -293,6 +294,40 @@ static void kasan_report_error(struct kasan_access_info *info)