Re: [PATCH] pinctrl: rockchip: add irq_enable & irq_disable ops

From: Linus Walleij
Date: Thu Mar 23 2017 - 05:05:46 EST


On Thu, Mar 2, 2017 at 6:56 AM, Jeffy Chen <jeffy.chen@xxxxxxxxxxxxxx> wrote:

> Currently we are trying to enable/disable the clk of irq's gpio bank when
> unmask/mask irq. But the kernel's "lazy disable approach" will skip masking
> irq when the irq chip doesn't support irq_disable ops.
>
> So we may hit this case:
> irq_enable-> enable clk
> irq_disable-> noop
> irq_enable-> enable clk again
> irq_disable-> noop
>
> Signed-off-by: Jeffy Chen <jeffy.chen@xxxxxxxxxxxxxx>

Patch applied with Heiko's review tag.

Yours,
Linus Walleij