Re: [PATCH 3/3] ACPI: Don't create a platform_device for IOAPIC/IOxAPIC

From: Rafael J. Wysocki
Date: Wed Mar 22 2017 - 19:41:36 EST


On Wed, Mar 22, 2017 at 11:58 PM, Joerg Roedel <jroedel@xxxxxxx> wrote:
> Hi Rafael,
>
> On Wed, Mar 22, 2017 at 06:42:39PM +0100, Rafael J. Wysocki wrote:
>> On Wednesday, March 22, 2017 06:33:25 PM Joerg Roedel wrote:
>> > From: Joerg Roedel <jroedel@xxxxxxx>
>> >
>> > No platform-device is required for IO(x)APICs, so don't even
>> > create them.
>> >
>> > Signed-off-by: Joerg Roedel <jroedel@xxxxxxx>
>>
>> If we do this, I'd prefer not to do [2/3], because we'll introduce code that
>> will be essentially dead then.
>
> In this case the code in acpi_bus_attach() adding platform_devices is also
> dead. Could it be removed then?

It is not dead.

Platform devices are actually created by it, but they never go away.

Thanks,
Rafael