Re: [2/2] zd1211rw: fix NULL-deref at probe

From: Kalle Valo
Date: Wed Mar 22 2017 - 09:05:37 EST


Johan Hovold <johan@xxxxxxxxxx> writes:

> On Wed, Mar 22, 2017 at 09:04:15AM +0000, Kalle Valo wrote:
>> Johan Hovold <johan@xxxxxxxxxx> wrote:
>> > Make sure to check the number of endpoints to avoid dereferencing a
>> > NULL-pointer or accessing memory beyond the endpoint array should a
>> > malicious device lack the expected endpoints.
>> >
>> > Fixes: a1030e92c150 ("[PATCH] zd1211rw: Convert installer CDROM
>> > device into WLAN device")
>> > Cc: Daniel Drake <dsd@xxxxxxxxxx>
>> > Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
>>
>> Patch applied to wireless-drivers-next.git, thanks.
>>
>> ca260ece6a57 zd1211rw: fix NULL-deref at probe
>
> What about patch 1/2 which fixes the same bug (literally copied from the
> zd1211rw driver)?

I will apply that to my separate ath.git tree, just didn't get to your
patch yet.

> And as these fixes should be backported to stable (I left out the tag
> for networking drivers)

Actually for wireless drivers you should add the stable tag.

> why only apply to -next?

I didn't see that the fix was important enough for 4.11.

--
Kalle Valo