Re: [PATCH net-next 1/8] ptr_ring: introduce batch dequeuing

From: Jason Wang
Date: Tue Mar 21 2017 - 23:16:50 EST




On 2017å03æ21æ 18:25, Sergei Shtylyov wrote:
Hello!

On 3/21/2017 7:04 AM, Jason Wang wrote:

Signed-off-by: Jason Wang <jasowang@xxxxxxxxxx>
---
include/linux/ptr_ring.h | 65 ++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 65 insertions(+)

diff --git a/include/linux/ptr_ring.h b/include/linux/ptr_ring.h
index 6c70444..4771ded 100644
--- a/include/linux/ptr_ring.h
+++ b/include/linux/ptr_ring.h
@@ -247,6 +247,22 @@ static inline void *__ptr_ring_consume(struct ptr_ring *r)
return ptr;
}

+static inline int __ptr_ring_consume_batched(struct ptr_ring *r,
+ void **array, int n)
+{
+ void *ptr;
+ int i = 0;
+
+ while (i < n) {

Hm, why not *for*?

Yes, it maybe better, if there's other comment on the series, will change it in next version.

Thanks