Re: [PATCH] checkpatch: Flag spam header (X-Spam-Report) to prevent spurious warnings

From: Joe Perches
Date: Tue Mar 21 2017 - 14:54:57 EST


On Tue, 2017-03-21 at 09:30 -0700, John 'Warthog9' Hawley (VMware) wrote:
> Spamassassin sticks a long (~79 character) long string after a
> line that has a single space in it. The line with space causes
> checkpatch to erroniously think that it's in the content body, as
> opposed to headers and thus flag a mail header as an unwrapped long
> comment line.

If the spammassassin header is like

email-header-n: foo
email-header-m: bar

X-Spam-Report: bar

Does that form follow rfc 5322?

If it does then any email header could have that
form and the header wrapping test should be
updated from

if ($in_header_lines && $realfile =~ /^$/ &&
    !($rawline =~ /^\s+\S/ ||
      $rawline =~ /^(commit\b|from\b|[\w-]+:).*$/i)) {
$in_header_lines = 0;
$in_commit_log = 1;
$has_commit_log = 1;
}

to something like

if ($in_header_lines && $realfile =~ /^$/ &&
    !($rawline =~ /^ (?:\s*\S|$)/ ||
$rawline =~ /^(commit\b|from\b|[\w-]+:).*$/i)) {