Re: [PATCH] hid: cp2112: select GPIOLIB_IRQCHIP instead of depending on it

From: Jiri Kosina
Date: Tue Mar 21 2017 - 10:31:07 EST


On Sun, 12 Mar 2017, Bartosz Golaszewski wrote:

> GPIOLIB_IRQCHIP is not visible to user, so we can't depend on it.
>
> Depend on GPIOLIB but select GPIOLIB_IRQCHIP.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> ---
> drivers/hid/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 1aeb80e..00e2809 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -214,7 +214,8 @@ config HID_CMEDIA
>
> config HID_CP2112
> tristate "Silicon Labs CP2112 HID USB-to-SMBus Bridge support"
> - depends on USB_HID && I2C && GPIOLIB && GPIOLIB_IRQCHIP
> + depends on USB_HID && I2C && GPIOLIB
> + select GPIOLIB_IRQCHIP
> ---help---
> Support for Silicon Labs CP2112 HID USB to SMBus Master Bridge.
> This is a HID device driver which registers as an i2c adapter

Applied, thanks.

--
Jiri Kosina
SUSE Labs