Re: [PATCH] usb: gadget: Correct usb EP argument for BOT status request

From: Nicholas A. Bellinger
Date: Tue Mar 21 2017 - 03:12:37 EST


Hi Manish,

(Added target-devel CC')

On Mon, 2017-03-20 at 15:05 +0530, Manish Narani wrote:
> This patch corrects the argument in usb_ep_free_request as it is
> mistakenly set to ep_out. It should be ep_in for status request.
>
> Signed-off-by: Manish Narani <mnarani@xxxxxxxxxx>
> ---
> drivers/usb/gadget/function/f_tcm.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/gadget/function/f_tcm.c b/drivers/usb/gadget/function/f_tcm.c
> index d235113..a82e2bd 100644
> --- a/drivers/usb/gadget/function/f_tcm.c
> +++ b/drivers/usb/gadget/function/f_tcm.c
> @@ -373,7 +373,7 @@ static void bot_cleanup_old_alt(struct f_uas *fu)
> usb_ep_free_request(fu->ep_in, fu->bot_req_in);
> usb_ep_free_request(fu->ep_out, fu->bot_req_out);
> usb_ep_free_request(fu->ep_out, fu->cmd.req);
> - usb_ep_free_request(fu->ep_out, fu->bot_status.req);
> + usb_ep_free_request(fu->ep_in, fu->bot_status.req);
>
> kfree(fu->cmd.buf);
>

Applied to target-pending/master.

Thanks!