Re: [net-next PATCH 2/2] tcp: Record Rx hash and NAPI ID in tcp_child_process

From: Eric Dumazet
Date: Mon Mar 20 2017 - 18:06:26 EST


On Mon, Mar 20, 2017 at 2:48 PM, Alexander Duyck
<alexander.duyck@xxxxxxxxx> wrote:
> From: Alexander Duyck <alexander.h.duyck@xxxxxxxxx>
>
> While working on some recent busy poll changes we found that child sockets
> were being instantiated without NAPI ID being set. In our first attempt to
> fix it, it was suggested that we should just pull programming the NAPI ID
> into the function itself since all callers will need to have it set.
>
> In addition to NAPI ID I have decided to also pull in populating the Rx
> hash since it likely has the same problem as NAPI ID but just doesn't have
> the visibility.

It looks like Rx hash was initialized elsewhere (
tcp_get_cookie_sock() & tcp_check_req())

So this probably could be cleaned up, if done at the proper place ;)