Re: [PATCH net-next] stmmac: call stmmac_init_phy from stmmac_dvr_probe

From: Joao Pinto
Date: Mon Mar 20 2017 - 13:42:43 EST


Às 5:29 PM de 3/20/2017, Niklas Cassel escreveu:
> From: Niklas Cassel <niklas.cassel@xxxxxxxx>
>
> It is usually possible to do
> ethtool -s autoneg on
> so that you trigger an autoneg before calling
> ip link set dev eth0 up
>
> However, stmmac returns -EBUSY if !netif_running.
> The only reason for this appears to be that stmmac_init_phy
> is called from stmmac_open instead of from stmmac_dvr_probe.
>
> Move stmmac_init_phy to stmmac_dvr_probe so that ethool
> works as soon as register_netdev has been called.
> stmmac_check_ether_addr was also moved to probe,
> so that the ordering doesn't change.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@xxxxxxxx>
> ---

Hi Niklas, did you test this patch?

Thanks.
Joao