Re: [PATCH] staging: vc04_services: fix NULL pointer dereference on pointer 'service'

From: Stefan Wahren
Date: Mon Mar 20 2017 - 10:48:43 EST


[add Mauro to CC]

Am 20.03.2017 um 15:08 schrieb Colin King:
From: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Currently, if pservice is null then service is set to NULL and immediately
afterwards service is dereferenced causing a null pointer dereference. Fix
this by bailing out early of the function with a null return.

Detected by CoverityScan, CID#1419681 ("Explicit null dereferenced")

Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Acked-by: Stefan Wahren <stefan.wahren@xxxxxxxx>