Re: [PATCH 4/4] tty/serial: sh-sci: remove uneeded IS_ERR_OR_NULL calls

From: Geert Uytterhoeven
Date: Mon Mar 20 2017 - 06:50:24 EST


Hi Uwe,

On Mon, Mar 20, 2017 at 11:31 AM, Uwe Kleine-KÃnig
<u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
> On Mon, Mar 20, 2017 at 10:56:14AM +0100, Geert Uytterhoeven wrote:
>> Documentation/gpio/consumer.txt rightfully sates:
>> | Note that gpio_get*_optional() functions (and their managed variants), unlike
>> | the rest of gpiolib API, also return NULL when gpiolib support is disabled.
>> | This is helpful to driver authors, since they do not need to special case
>> | -ENOSYS return codes. System integrators should however be careful to enable
>> | gpiolib on systems that need it.
>
> I cannot find this paragraph in Documentation/gpio/consumer.txt:
>
> $ git grep -e 'ENOSYS' v4.11-rc3 -- Documentation/gpio/
> <void>

It was added by commit 22c403676dbbb7c6 ("gpio: return NULL from
gpiod_get_optional when GPIOLIB is disabled")

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds