Re: [PATCH v2 15/17] iio: pressure: mpl3115: Add OF device ID table

From: Jonathan Cameron
Date: Sun Mar 19 2017 - 06:58:27 EST


On 15/03/17 04:45, Javier Martinez Canillas wrote:
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
>
> But this could change in the future so the correct approach is to have an
> OF device ID table if the devices are registered via OF.
>
> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
Applied.
> ---
>
> drivers/iio/pressure/mpl3115.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/iio/pressure/mpl3115.c b/drivers/iio/pressure/mpl3115.c
> index 525644a7442d..619b963714c7 100644
> --- a/drivers/iio/pressure/mpl3115.c
> +++ b/drivers/iio/pressure/mpl3115.c
> @@ -321,9 +321,16 @@ static const struct i2c_device_id mpl3115_id[] = {
> };
> MODULE_DEVICE_TABLE(i2c, mpl3115_id);
>
> +static const struct of_device_id mpl3115_of_match[] = {
> + { .compatible = "fsl,mpl3115" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, mpl3115_of_match);
> +
> static struct i2c_driver mpl3115_driver = {
> .driver = {
> .name = "mpl3115",
> + .of_match_table = mpl3115_of_match,
> .pm = MPL3115_PM_OPS,
> },
> .probe = mpl3115_probe,
>