Re: [PATCH v1 2/3] blk-mq: comment on races related with timeout handler

From: Hannes Reinecke
Date: Sat Mar 18 2017 - 07:25:34 EST


On 03/17/2017 10:57 AM, Ming Lei wrote:
> This patch adds comment on two races related with
> timeout handler:
>
> - requeue from queue busy vs. timeout
> - rq free & reallocation vs. timeout
>
> Both the races themselves and current solution aren't
> explicit enough, so add comments on them.
>
> Cc: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>
> Signed-off-by: Ming Lei <tom.leiming@xxxxxxxxx>
> ---
> block/blk-mq.c | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>

Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@xxxxxxx +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)