Re: [PATCH v2] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

From: Mark Brown
Date: Fri Mar 17 2017 - 09:41:38 EST


On Fri, Mar 17, 2017 at 02:41:04AM +0000, Kai-Heng Feng wrote:
> On Thu, Mar 16, 2017 at 10:09 PM Mark Brown <broonie@xxxxxxxxxx> wrote:

> > > + rt286->is_dell_dino = dmi_check_system(dmi_dell_dino) ? true :
> > false;

> > Just directly assign the boolean value, the ternery operator is just
> > making thins harder to read here.

> Should I make the int implicitly convert to bool or use '!!' operator?

Use implicit conversion like you're already doing - the above already
evaluates the function as a boolean in order to use it in the ternery
operator.

Attachment: signature.asc
Description: PGP signature