Re: [RFC PATCH] drivers: ata: Add [save|restore]_initial_config override functions

From: Tejun Heo
Date: Thu Mar 16 2017 - 17:30:45 EST


On Tue, Mar 14, 2017 at 05:29:21PM +0530, Anurag Kumar Vulisha wrote:
> @@ -613,7 +613,10 @@ static void ahci_pci_save_initial_config(struct pci_dev *pdev,
> "Disabling your PATA port. Use the boot option 'ahci.marvell_enable=0' to avoid this.\n");
> }
>
> - ahci_save_initial_config(&pdev->dev, hpriv);
> + if (hpriv->save_initial_config == NULL)
> + ahci_save_initial_config(dev, hpriv);
> + else
> + hpriv->save_initial_config(dev, hpriv);

Can you just initialize hpriv->save_initial_config to
ahci_save_initial_config and let the init function override it as
necessary?

Thanks.

--
tejun