Re: [PATCH 02/15] mm: page_alloc: align arguments to parenthesis

From: Michal Hocko
Date: Thu Mar 16 2017 - 06:33:12 EST


On Thu 16-03-17 03:29:27, Joe Perches wrote:
> On Thu, 2017-03-16 at 09:02 +0100, Michal Hocko wrote:
> > On Wed 15-03-17 18:59:59, Joe Perches wrote:
> > > whitespace changes only - git diff -w shows no difference
> >
> > what is the point of this whitespace noise? Does it help readability?
>
> Yes. Consistency helps.

Causing context conflicts doesn't though.

> > To be honest I do not think so.
>
> Opinions always vary.

Yes the vary and I do not like this. If you find somebody to ack then I
will not complain but I would appreciate if a more useful stuff was done
in mm/page_alloc.c
--
Michal Hocko
SUSE Labs