Re: [PATCH 1/2] x86/head_64.S: Rename start_cpu()

From: Ingo Molnar
Date: Tue Mar 07 2017 - 09:56:44 EST



* Borislav Petkov <bp@xxxxxxxxx> wrote:

> On Tue, Mar 07, 2017 at 10:06:38AM +0100, Ingo Molnar wrote:
> > The local labels syntax is silly, I always end up looking twice to make sense of
> > 'Ljump' or 'Lwhatever' ;-)
> >
> > We cannot do anything about that - but we can name our symbols to work it around.
> > But the price is the extra underscore in the symbol name...
>
> Sure, but other labels in this file don't have the preceding "_".

Yeah, and that would make it all inconsistent - fair enough.

Ok, I'll apply your patch as-is.

> Perhaps we should agree on a convention for the local labels naming in
> our asm and adhere to it...

Too much churn I suspect, plus we'd generate extra churn when people inevitably
get it wrong.

Thanks,

Ingo