Re: [PATCH v2] MIPS: Fix build breakage caused by header file changes

From: Guenter Roeck
Date: Mon Mar 06 2017 - 15:04:26 EST


On Sun, Mar 05, 2017 at 09:53:20PM -0800, Guenter Roeck wrote:
> Since commit f3ac60671954 ("sched/headers: Move task-stack related
> APIs from <linux/sched.h> to <linux/sched/task_stack.h>") and commit
> f780d89a0e82 ("sched/headers: Remove <asm/ptrace.h> from
> <linux/sched.h>"), various mips builds fail as follows.
>
> arch/mips/kernel/smp-mt.c: In function âvsmp_boot_secondaryâ:
> arch/mips/include/asm/processor.h:384:41: error:
> implicit declaration of function âtask_stack_pageâ
>
> In file included from
> /opt/buildbot/slave/hwmon-testing/build/arch/mips/kernel/pm.c:
> arch/mips/include/asm/fpu.h: In function '__own_fpu':
> arch/mips/include/asm/processor.h:385:31: error:
> invalid application of 'sizeof' to incomplete type 'struct pt_regs'
>
> arch/mips/netlogic/common/smp.c: In function 'nlm_boot_secondary':
> arch/mips/netlogic/common/smp.c:157:2: error:
> implicit declaration of function 'task_stack_page'
>
> arch/mips/cavium-octeon/cpu.c: In function 'cnmips_cu2_call':
> arch/mips/include/asm/processor.h:386:36: error:
> implicit declaration of function 'task_stack_page'
>
> Fixes: f3ac60671954 ("sched/headers: Move task-stack related APIs ...")
> Fixes: f780d89a0e82 ("sched/headers: Remove <asm/ptrace.h> from ...")
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> v2: More files needed a fix.

Sigh. More breakage found. v3 coming.

Guenter