Re: [PATCH 4/4] arm: dts: rockchip: Enable post_ios_power_on and pre-power-on-delay-ms

From: Heiko Stuebner
Date: Wed Mar 01 2017 - 18:00:13 EST


Hi Romain,

Am Mittwoch, 1. März 2017, 15:53:10 CET schrieb Romain Perier:
> This enables the property post_ios_power_on. With this property, the
> driver pwrseq_simple will do its entire power sequence at the end of the
> mmc_power_up() function. The property pre-power-on-delay-ms adds a delay
> of 1ms between the enablement of the clk and the assertion of the reset
> line.
>
> It fixes the power-up sequence for the Wifi chipset AP6335.
>
> Signed-off-by: Romain Perier <romain.perier@xxxxxxxxxxxxx>

I didn't get the other 3 patches touching the mmc subsystem, so if and when
they get accepted, please ping this devicetree patch.


> ---
> arch/arm/boot/dts/rk3288-rock2-square.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288-rock2-square.dts
> b/arch/arm/boot/dts/rk3288-rock2-square.dts index 818c4bf..9bf2991 100644
> --- a/arch/arm/boot/dts/rk3288-rock2-square.dts
> +++ b/arch/arm/boot/dts/rk3288-rock2-square.dts
> @@ -106,6 +106,8 @@
> pinctrl-names = "default";
> pinctrl-0 = <&wifi_enable>;
> reset-gpios = <&gpio4 28 GPIO_ACTIVE_LOW>;
> + pre-power-on-delay-ms = <1>;
> + post-ios-power-on;

If you need to resend your series, please make sure you have alphabetically
sorted properties -> pinctrl, post-ios-..., pre-power-... and finally reset-
gpios. No need to resend just for this though, as I can reorder them myself if
needed.


Thanks
Heiko