Re: [PATCH] [RFC] x86: avoid -mtune=atom for objtool warnings

From: Arnd Bergmann
Date: Wed Mar 01 2017 - 17:43:17 EST


On Wed, Mar 1, 2017 at 5:53 PM, Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
> On Wed, Mar 01, 2017 at 04:27:29PM +0100, Arnd Bergmann wrote:

> I see no apparent reason for the ud2.

It's the possible division by zero. This change would avoid the ud2:

diff --git a/drivers/i2c/busses/i2c-img-scb.c b/drivers/i2c/busses/i2c-img-scb.c
index db8e8b40569d..a2b09c518225 100644
--- a/drivers/i2c/busses/i2c-img-scb.c
+++ b/drivers/i2c/busses/i2c-img-scb.c
@@ -1196,6 +1196,8 @@ static int img_i2c_init(struct img_i2c *i2c)
clk_khz /= prescale;

/* Setup the clock increment value */
+ if (clk_khz < 1)
+ clk_khz = 1;
inc = (256 * 16 * bitrate_khz) / clk_khz;

/*


Arnd