Re: [Xen-devel] [PATCH 1/5] x86/xen: start untangling PV and PVHVM guest support code

[Vitaly Kuznetsov]

Juergen Gross <jgross@xxxxxxxx> writes:

> On 24/02/17 17:14, Vitaly Kuznetsov wrote:
>> Introduce CONFIG_XEN_PV config option and split enlighten.c into
>> 4 files. Temporary add #ifdef CONFIG_XEN_PV to smp.c and mmu.c to
>> not break the build and not make the patch even bigger.
>> 
>> xen_cpu_up_prepare*/xen_cpu_die hooks require separation to support
>> future xen_smp_intr_init() split.
>> 
>> Signed-off-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>
>
> Could you please split pure code movement and functional changes into
> different patches? This would make review much easier.
>

It's a bit hard with this series to make patches smaller and not break
the build ... :-(

> So 1 patch to split up enlightenment.c and at least one patch for the
> rest of the changes (Kconfig, splitting of x86_hyper_xen, ...).

This sounds doable, I'll try!

-- 
  Vitaly