Re: [Outreachy kernel] Re: [PATCH v2 3/3] staging: rtl8192u: Prefer using the BIT macro

From: Greg KH
Date: Sat Feb 25 2017 - 02:55:56 EST


On Fri, Feb 24, 2017 at 12:10:21PM -0800, SIMRAN SINGHAL wrote:
>
>
> On Friday, February 24, 2017 at 10:46:21 PM UTC+5:30, gregkh wrote:
>
> On Fri, Feb 17, 2017 at 11:20:59PM +0530, simran singhal wrote:
> > Replaces left shift operation (1 << d) by BIT(x) macro.
> >
> > Fix the checkpatch.pl issue:
> > CHECK: Prefer using the BIT macro replacing
> >
> > Signed-off-by: simran singhal <singhal...@xxxxxxxxx>
> > ---
> >  
> >  V2:
> >    -modified patch message.
> >
> >  drivers/staging/rtl8192u/ieee80211/ieee80211.h | 140
> ++++++++++++-------------
> >  1 file changed, 70 insertions(+), 70 deletions(-)
>
> The last chunk of this patch did not apply, please fix up and resend.
>
> thanks,
>
> greg k-h
>
>
>   Can you please elaborate what's the problem with the last chunk of this patch
> and 
>   to be more precise what do you mean by "last chunk of this patch". I am not
> getting 
>   what's the problem with this patch.

I don't know what the problem was, just that it did not apply properly.
Take your patch and try to apply it now to my tree and see what
happens...

thanks,

greg k-h