Re: [PATCH net] rxrpc: Fix an assertion in rxrpc_read()

From: David Miller
Date: Fri Feb 24 2017 - 11:32:56 EST


From: David Howells <dhowells@xxxxxxxxxx>
Date: Fri, 24 Feb 2017 12:33:09 +0000

> From: Marc Dionne <marc.dionne@xxxxxxxxxxxx>
>
> In the rxrpc_read() function, which allows a user to read the contents of a
> key, we miscalculate the expected length of an encoded rxkad token by not
> taking into account the key length. However, the data is stored later
> anyway with an ENCODE_DATA() call - and an assertion failure then ensues
> when the lengths are checked at the end.
>
> Fix this by including the key length in the token size estimation.
>
> The following assertion is produced:
...
> Signed-off-by: Marc Dionne <marc.dionne@xxxxxxxxxxxx>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>

Applied.