Re: [PATCH v2 0/4] PTP attribute handling cleanup

From: David Miller
Date: Wed Feb 15 2017 - 12:22:20 EST


From: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
Date: Tue, 14 Feb 2017 10:23:30 -0800

> PTP core was creating some attributes, such as "period" and "fifo", and the
> entire "pins" attribute group, after creating class deevice, which creates
> a race for userspace: uevent may arrive before all attributes are created.
>
> This series of patches switches PTP to use is_visible() to control
> visibility of attributes in a group, and device_create_with_groups() to
> ensure that attributes are created before we notify userspace of a new
> device.

Richard, please review.