Re: [PATCH]staging: fbtft: Fix sparse warnings about endianness

From: Greg KH
Date: Tue Feb 14 2017 - 12:18:35 EST


On Tue, Feb 14, 2017 at 04:53:10PM +0800, maomao xu wrote:
> Fixed sparse warnings about endianness. E.g.:
>
> warning: incorrect type in assignment (different base types)

Why are these lines indented?

> Signed-off-by: maomao xu <albert008.xu@xxxxxxxxx>
>
> diff --git a/drivers/staging/fbtft/fbtft-io.c b/drivers/staging/fbtft/fbtft-io.c
> index d868405..ffb9a3b 100644
> --- a/drivers/staging/fbtft/fbtft-io.c
> +++ b/drivers/staging/fbtft/fbtft-io.c
> @@ -71,7 +71,7 @@ int fbtft_write_spi_emulate_9(struct fbtft_par *par, void *buf, size_t len)
> src++;
> }
> tmp |= ((*src & 0x0100) ? 1 : 0);
> - *(u64 *)dst = cpu_to_be64(tmp);
> + *(__be64 *)dst = cpu_to_be64(tmp);

Really? That seems very odd. I need a maintainer's ack for this before
I can take it...

thanks,

greg k-h