Re: [PATCH v2 8/9] sched: Don't reinvent the wheel but use existing llist API

From: Oleg Nesterov
Date: Mon Feb 13 2017 - 10:54:01 EST


On 02/13, Peter Zijlstra wrote:
>
> On Mon, Feb 13, 2017 at 04:21:08PM +0900, Byungchul Park wrote:
> > + llist_for_each_entry(p, llist, wake_entry)
> > + ttwu_do_activate(rq, p, p->sched_remote_wakeup ? WF_MIGRATED : 0, &rf);
>
> I think this suffers the exact same problem the others did. After
> ttwu_do_activate() the llist entry can be reused, so doing list_next()
> after it is flaky.

llist_for_each_entry_safe() should work, I guess.

Oleg.