Re: [PATCH] x86/vm86: fix unused variable warning if THP is disabled.

From: Thomas Gleixner
Date: Mon Feb 13 2017 - 10:49:59 EST


On Mon, 13 Feb 2017, Kirill A. Shutemov wrote:

> GCC complaines on unused variable 'vma' in mark_screen_rdonly() if THP
> is disalbed:
>
> arch/x86/kernel/vm86_32.c: In function âmark_screen_rdonlyâ:
> arch/x86/kernel/vm86_32.c:180:26: warning: unused variable âvmaâ
> [-Wunused-variable]
> struct vm_area_struct *vma = find_vma(mm, 0xA0000);
> ^~~
> It shoudln't really. The whole block has to be eliminated as
> pmd_trans_huge() is 0 if THP is disabled.

Indeed. That's outright silly.