Re: [PATCH v2 2/5] time: mark syscore_ops as __ro_after_init

From: John Stultz
Date: Fri Feb 10 2017 - 21:12:51 EST


On Fri, Feb 10, 2017 at 5:37 PM, Jess Frazelle <me@xxxxxxxxxxxx> wrote:
> Marked syscore_ops structs as __ro_after_init when register_syscore_ops was
> called only during init. Most of the caller functions were already annotated as
> __init.
> unregister_syscore_ops() was never called on these ops.
> This protects the data structure from accidental corruption.
>
> Suggested-by: Kees Cook <keescook@xxxxxxxxxxxx>
> Signed-off-by: Jess Frazelle <me@xxxxxxxxxxxx>
> Acked-by: Rik van Riel <riel@xxxxxxxxxx>

Thanks for sending this out. Looks reasonable to me. I'll queue it for
testing, targeting for 4.12.

thanks
-john