[PATCH] checkpatch: add warning on %pk instead of %pK usage

From: william . c . roberts
Date: Fri Feb 10 2017 - 14:38:12 EST


From: William Roberts <william.c.roberts@xxxxxxxxx>

Sample output:
WARNING: %pk is close to %pK, did you mean %pK?.
\#20: FILE: drivers/char/applicom.c:230:
+ printk(KERN_INFO "Could not allocate IRQ %d for PCI Applicom device. %pk\n", dev->irq, pci_get_class);

Signed-off-by: William Roberts <william.c.roberts@xxxxxxxxx>
---
scripts/checkpatch.pl | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 982c52c..f20f5c5 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -6096,6 +6096,12 @@ sub process {
"recursive locking is bad, do not use this ever.\n" . $herecurr);
}

+# check for bad %pK usage
+ if ($rawline =~ /\%pk/) {
+ WARN("FORMAT SPECIFIER",
+ "%pk is close to %pK, did you mean %pK?.\n" . $herecurr);
+ }
+
# check for lockdep_set_novalidate_class
if ($line =~ /^.\s*lockdep_set_novalidate_class\s*\(/ ||
$line =~ /__lockdep_no_validate__\s*\)/ ) {
--
2.7.4