Re: [PATCH v4] eeprom/at24: use device_property_*() functions instead of of_get_property()

From: Wolfram Sang
Date: Fri Feb 10 2017 - 10:35:23 EST


On Thu, Feb 09, 2017 at 11:36:08AM -0600, Ben Gardner wrote:
> Allow the at24 driver to get configuration information from both OF and
> ACPI by using the more generic device_property functions.
> This change was inspired by the at25.c driver.
>
> I have a custom board with a ST M24C02 EEPROM attached to an I2C bus.
> With the following ACPI construct, this patch instantiates a working
> instance of the driver.
>
> Device (EEP0) {
> Name (_HID, "PRP0001")
> Name (_DSD, Package () {
> ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> Package () {
> Package () {"compatible", Package () {"st,24c02"}},
> Package () {"pagesize", 16},
> },
> })
> Name (_CRS, ResourceTemplate () {
> I2cSerialBus (
> 0x0057, ControllerInitiated, 400000,
> AddressingMode7Bit, "\\_SB.PCI0.I2C3", 0x00,
> ResourceConsumer,,)
> })
> }
>
> Note: Matching the driver to the I2C device requires another patch.
> http://www.spinics.net/lists/linux-acpi/msg71914.html

This should have been below the "---" because dependencies are not
relevant in the git history.

>
> Signed-off-by: Ben Gardner <gardner.ben@xxxxxxxxx>

Please send new patches not in-reply-to old patches, seperate threads
are easier to find IMHO.

Other than that:

Applied to for-next, thanks!


Attachment: signature.asc
Description: PGP signature