Re: [PATCH v12 6/9] usb: xhci: use bus->sysdev for DMA configuration

From: Peter Chen
Date: Wed Feb 08 2017 - 23:00:43 EST


On Wed, Feb 08, 2017 at 05:27:31PM +0530, Vivek Gautam wrote:
> Hi,
>
>
> On Mon, Feb 6, 2017 at 2:43 PM, Peter Chen <peter.chen@xxxxxxx> wrote:
> > From: Arnd Bergmann <arnd@xxxxxxxx>
> >
> > For xhci-hcd platform device, all the DMA parameters are not
> > configured properly, notably dma ops for dwc3 devices. So, set
> > the dma for xhci from sysdev. sysdev is pointing to device that
> > is known to the system firmware or hardware.
> >
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> > Signed-off-by: Sriram Dash <sriram.dash@xxxxxxx>
> > Tested-by: Baolin Wang <baolin.wang@xxxxxxxxxx>
> > Tested-by: Vivek Gautam <vivek.gautam@xxxxxxxxxxxxxx>
> > Tested-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx>
> > Signed-off-by: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
> > ---
>
> This patch doesn't work for me anymore on db820c target [1].
> While the same kernel with reverts of patches [2] [3] and an older
> patch [4] by Grygorii Strashko works [5].
>
> [1] https://github.com/vivekgautam1/linux/tree/linux-v4.10-rc7-usb-db820c-nonworking
> [2] 8c9f2de459c7 usb: dwc3: Do not set dma coherent mask
> [3] d64ff406e51e usb: dwc3: use bus->sysdev for DMA configuration
> [4] https://lkml.org/lkml/2016/4/25/813
> [5] https://github.com/vivekgautam1/linux/tree/linux-v4.10-rc7-usb-db820c
>
>

The [2] and [3] have already at mainline, you may talk with Felipe about
it.

--

Best Regards,
Peter Chen