Re: [PATCH] mtd: ichxrom: maybe-uninitialized with gcc-4.9

From: Brian Norris
Date: Wed Feb 08 2017 - 17:24:42 EST


On Mon, Oct 24, 2016 at 10:47:59PM +0200, Marek Vasut wrote:
> On 10/24/2016 05:28 PM, Arnd Bergmann wrote:
> > pci_read_config_word() might fail and not initialize its output,
> > as pointed out by older versions of gcc when using the -Wmaybe-unintialized
> > flag:
> >
> > drivers/mtd/maps/ichxrom.c: In function âichxrom_cleanupâ:
> > drivers/mtd/maps/ichxrom.c:63:2: error: âwordâ is used uninitialized in this function [-Werror=uninitialized]
> >
> > This is apparently a correct warning, though it does not show up
> > with newer compilers. Changing the code to not attempt to write
> > back uninitialized data into PCI config space is a correct
> > fix for the problem and avoids the warning.
> >
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> Reviewed-by: Marek Vasut <marex@xxxxxxx>

Applied to l2-mtd.git