Re: [PATCH v2 1/2] kconfig/mconf: add jumping tip in title of search result textbox

From: Jani Nikula
Date: Wed Feb 08 2017 - 03:08:12 EST


On Wed, 08 Feb 2017, changbin.du@xxxxxxxxx wrote:
> From: Changbin Du <changbin.du@xxxxxxxxx>
>
> Prompt user how to quickly jump to the item he/she is interested in.
>
> Signed-off-by: Changbin Du <changbin.du@xxxxxxxxx>
> Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>

This is assuming too much... but I looked at it now, and it looks good
to me.

Thanks,
Jani.

> ---
> scripts/kconfig/mconf.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
> index 315ce2c..23d5681 100644
> --- a/scripts/kconfig/mconf.c
> +++ b/scripts/kconfig/mconf.c
> @@ -443,10 +443,10 @@ static void search_conf(void)
>
> res = get_relations_str(sym_arr, &head);
> set_subtitle();
> - dres = show_textbox_ext(_("Search Results"), (char *)
> - str_get(&res), 0, 0, keys, &vscroll,
> - &hscroll, &update_text, (void *)
> - &data);
> + dres = show_textbox_ext(
> + _("Search Results (type the number to jump)"),
> + (char *)str_get(&res), 0, 0, keys, &vscroll,
> + &hscroll, &update_text, (void *)&data);
> again = false;
> for (i = 0; i < JUMP_NB && keys[i]; i++)
> if (dres == keys[i]) {

--
Jani Nikula, Intel Open Source Technology Center