Re: [RESENT PATCH] ARM: bcm2835: Add devicetree for the Raspberry Pi 3, for arm (32)

From: Eric Anholt
Date: Tue Jan 31 2017 - 17:00:48 EST


Eric Anholt <eric@xxxxxxxxxx> writes:

> [ Unknown signature status ]
> Gerd Hoffmann <kraxel@xxxxxxxxxx> writes:
>
>> Signed-off-by: Gerd Hoffmann <kraxel@xxxxxxxxxx>
>> ---
>> arch/arm/boot/dts/Makefile | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 7327250..82a760d 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -70,7 +70,8 @@ dtb-$(CONFIG_ARCH_BCM2835) += \
>> bcm2835-rpi-b-plus.dtb \
>> bcm2835-rpi-a-plus.dtb \
>> bcm2836-rpi-2-b.dtb \
>> - bcm2835-rpi-zero.dtb
>> + bcm2835-rpi-zero.dtb \
>> + ../../../arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dtb
>> dtb-$(CONFIG_ARCH_BCM_5301X) += \
>> bcm4708-asus-rt-ac56u.dtb \
>> bcm4708-asus-rt-ac68u.dtb \
>
> This would be really nice to have.
>
> Acked-by: Eric Anholt <eric@xxxxxxxxxx>
>
> ARM upstream folks, do you have any issues with this?

Absent any feedback from ARM maintainers, I think we're about ready to
go with this.

Unfortunately, I just remembered yesterday that one of the requirements
is that we not use these sorts of ../../../ references in the DT tree.
Instead we have to use symlinks -- see arch/arm64/boot/dts/broadcom/ for
how we did the last round of this.

I think just having links from
arch/arm64/boot/dts/broadcom/bcm2837*.dts* to arch/arm/boot/dts/ would
be the solution, then this Makefile could just reference
bcm2837-rpi-3-b.dtb.

Would you be able to respin this?

Attachment: signature.asc
Description: PGP signature